feat(sink): refator es sink to support opensearch #16330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 5013 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2150 | 4 | 2859 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/BulkProcessorAdapter.java
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/ElasticBulkProcessorAdapter.java
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/OpensearchBulkProcessorAdapter.java
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/RestHighLevelClientAdapter.java
...r-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/BulkProcessorAdapter.java
Show resolved
Hide resolved
...risingwave-sink-es-7/src/main/java/com/risingwave/connector/ElasticBulkProcessorAdapter.java
Show resolved
Hide resolved
...ingwave-sink-es-7/src/main/java/com/risingwave/connector/OpensearchBulkProcessorAdapter.java
Show resolved
Hide resolved
.../risingwave-sink-es-7/src/main/java/com/risingwave/connector/RestHighLevelClientAdapter.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Apr 17, 2024
wenym1
reviewed
May 20, 2024
| @@ -77,10 +77,11 @@ | |||
| <commons.text.version>1.10.0</commons.text.version> | |||
| <commons.lang3.version>3.12.0</commons.lang3.version> | |||
| <debezium.version>2.4.2.Final</debezium.version> | |||
| <jackson.version>2.13.5</jackson.version> | |||
| <jackson.version>2.15.0</jackson.version> | |||
There was a problem hiding this comment.
Any reason to bump the version of jackson?
There was a problem hiding this comment.
opensearch api need 2.15.0+
.../risingwave-sink-es-7/src/main/java/com/risingwave/connector/BulkRequestConsumerFactory.java
Outdated
Show resolved
Hide resolved
...ingwave-sink-es-7/src/main/java/com/risingwave/connector/OpensearchBulkProcessorAdapter.java
Outdated
Show resolved
Hide resolved
...r-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/BulkProcessorAdapter.java
Outdated
Show resolved
Hide resolved
...risingwave-sink-es-7/src/main/java/com/risingwave/connector/ElasticBulkProcessorAdapter.java
Outdated
Show resolved
Hide resolved
...onnector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/EsSinkFactory.java
Outdated
Show resolved
Hide resolved
.../risingwave-sink-es-7/src/main/java/com/risingwave/connector/RestHighLevelClientAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
license-eye has totally checked 5065 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2164 | 2 | 2899 | 0 |
Click to see the invalid file list
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/ElasticRestHighLevelClientAdapter.java
- java/connector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/OpensearchRestHighLevelClientAdapter.java
...wave-sink-es-7/src/main/java/com/risingwave/connector/ElasticRestHighLevelClientAdapter.java
Show resolved
Hide resolved
...e-sink-es-7/src/main/java/com/risingwave/connector/OpensearchRestHighLevelClientAdapter.java
Show resolved
Hide resolved
xxhZs
force-pushed
the
xxh/support-opensearch
branch
from
43b946a to
8230237
Compare
xxhZs
force-pushed
the
xxh/support-opensearch
branch
from
8230237 to
e6b07a7
Compare
wenym1
reviewed
May 24, 2024
...onnector-node/risingwave-sink-es-7/src/main/java/com/risingwave/connector/EsSinkFactory.java
Show resolved
Hide resolved
...risingwave-sink-es-7/src/main/java/com/risingwave/connector/ElasticBulkProcessorAdapter.java
Outdated
Show resolved
Hide resolved
.../risingwave-sink-es-7/src/main/java/com/risingwave/connector/RestHighLevelClientAdapter.java
Outdated
Show resolved
Hide resolved
xxhZs
force-pushed
the
xxh/support-opensearch
branch
2 times, most recently
from
21b54db to
6c447c2
Compare
xxhZs
force-pushed
the
xxh/support-opensearch
branch
from
6c447c2 to
5848441
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 8d30b94 | ci/scripts/e2e-sink-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
xxhZs
added
the
need-cherry-pick-release-1.10
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Co-authored-by: Xinhao Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The interface structure of es and opensearch is exactly the same, and the input data format is exactly the same, but using the interface of es to call opensearch will cause compatibility problems, so we use the same data processing method to call the opensearch interface to support opensearch
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.