From 83c6e3c0499fad16ac034d4e0096a3a66b7e3688 Mon Sep 17 00:00:00 2001 From: Patrick Huang Date: Fri, 23 Feb 2024 22:14:16 +0800 Subject: [PATCH] fix(store): fix incorrect tombstone delete with memtable spill --- src/storage/src/hummock/compactor/compactor_runner.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/src/hummock/compactor/compactor_runner.rs b/src/storage/src/hummock/compactor/compactor_runner.rs index 710a6fb3c4a65..105ac4d3bcf73 100644 --- a/src/storage/src/hummock/compactor/compactor_runner.rs +++ b/src/storage/src/hummock/compactor/compactor_runner.rs @@ -818,7 +818,7 @@ where // in our design, frontend avoid to access keys which had be deleted, so we dont // need to consider the epoch when the compaction_filter match (it // means that mv had drop) - if (epoch <= task_config.watermark && task_config.gc_delete_keys && value.is_delete()) + if (epoch < task_config.watermark && task_config.gc_delete_keys && value.is_delete()) || (epoch < task_config.watermark && (watermark_can_see_last_key || earliest_range_delete_which_can_see_iter_key <= task_config.watermark))