Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update icelake #14920

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore: update icelake #14920

merged 1 commit into from
Feb 1, 2024

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Feb 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

update icelake

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@ZENOTME ZENOTME requested a review from a team as a code owner February 1, 2024 07:36
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removing unused import part is conflict with #14916. Rest LGTM

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Feb 1, 2024

The removing unused import part is conflict with #14916. Rest LGTM

Thanks! I rebase it later.

@ZENOTME ZENOTME enabled auto-merge February 1, 2024 08:33
@ZENOTME ZENOTME added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 822190b Feb 1, 2024
27 of 28 checks passed
@ZENOTME ZENOTME deleted the zj/update branch February 1, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants