feat(compaction): compact tier level at first when overlapping level too many #14482
Conversation
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
Signed-off-by: Little-Wallace <[email protected]>
| && level.vnode_partition_count > 0 | ||
| }) | ||
| .count(); | ||
| if (self.config.split_weight_by_vnode == 0 && no_overlap_count > overlapping_count) |
There was a problem hiding this comment.
This is good solution, please add some comments for the strategy.
| } | ||
| if self.config.split_weight_by_vnode > 0 |
There was a problem hiding this comment.
I always think about whether it is right to unconditionally compact l0 to base. This will lead to base-level accumulation. Should we continue to follow the selection rules of the level selector? What's your opinion?
Signed-off-by: Little-Wallace <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 2739c44 | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…too many (#14482) Signed-off-by: Little-Wallace <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When the number of tier level is too many, the level selector may keep selecting files of non-overlapping, it will cause a large write-amplification but it can not reduce the number of sub levels.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.