Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): try poll response stream error while sending request #12525

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Sep 25, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #12521

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wenym1 wenym1 enabled auto-merge September 25, 2023 13:34
@wenym1 wenym1 added this pull request to the merge queue Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #12525 (dfbe7ca) into main (d842cfa) will increase coverage by 0.00%.
Report is 5 commits behind head on main.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main   #12525   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files        1429     1429           
  Lines      238628   238636    +8     
=======================================
+ Hits       165666   165672    +6     
- Misses      72962    72964    +2     
Flag Coverage Δ
rust 69.42% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/rpc_client/src/lib.rs 86.00% <60.00%> (-4.22%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 31aa925 Sep 25, 2023
8 of 9 checks passed
@wenym1 wenym1 deleted the yiming/fix-remote-sink-exception branch September 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote sink writer gets stuck when connector node throws exception
3 participants