Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sink): impl SinkFormatter for DebeziumJsonFormatter #12372

Merged

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Prior PRs: #12264 #12321

Mostly moved from gen_debezium_message_stream.

Limitations:

  • Not generalized to handle DebeziumAvro yet.
  • Given that schema, pk_indices, db_name, sink_from_name are all fixed for a sink, certain calls (eg fields_pk_to_json) could have been made only once.
  • We may decouple per-chunk parameter ts_ms from other per-sink parameters so that we could build the per-sink formatter only once. formatter.with_ts(ts_ms).format_chunk(chunk). Alternatively, ts_ms could be extended to append-only and upsert as well.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #12372 (be420d9) into main (1877aed) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 51.68%.

@@            Coverage Diff             @@
##             main   #12372      +/-   ##
==========================================
- Coverage   69.84%   69.82%   -0.03%     
==========================================
  Files        1419     1420       +1     
  Lines      235577   235646      +69     
==========================================
+ Hits       164538   164539       +1     
- Misses      71039    71107      +68     
Flag Coverage Δ
rust 69.82% <51.68%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connector/src/sink/kafka.rs 28.06% <0.00%> (-7.81%) ⬇️
src/connector/src/sink/kinesis.rs 0.00% <0.00%> (ø)
src/connector/src/sink/utils.rs 100.00% <ø> (+28.44%) ⬆️
src/connector/src/sink/formatter/debezium_json.rs 53.48% <53.48%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit cc7e506 Sep 18, 2023
@xiangjinwu xiangjinwu deleted the refactor-sink-format-encode-2-DebeziumJsonFormatter branch September 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants