refactor(sink): impl SinkFormatter for DebeziumJsonFormatter #12372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Prior PRs: #12264 #12321
Mostly moved from
gen_debezium_message_stream
.Limitations:
schema
,pk_indices
,db_name
,sink_from_name
are all fixed for a sink, certain calls (egfields_pk_to_json
) could have been made only once.ts_ms
from other per-sink parameters so that we could build the per-sink formatter only once.formatter.with_ts(ts_ms).format_chunk(chunk)
. Alternatively,ts_ms
could be extended to append-only and upsert as well.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.