-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove ci main workflow #12232
Conversation
I guess this has added bonus of only having to make sure 2 pipelines are stable rather than monitoring 3 different ones. The main thing to note is that we lose test coverage on release build for each main commit. Now only 1 main commit at the end of the day will be tested via I think we can merge it, see how it performs. If there's many errors which are only found in |
In fact, we are not paying attention to every failed main pipeline now. In the future, we only need to strictly pay attention to the failed main-cron pipeline. |
You are right, it is not strictly paid attention to. I think this would be the alternative then, since it would block PRs from merging unless it passes:
|
Codecov Report
@@ Coverage Diff @@
## main #12232 +/- ##
==========================================
- Coverage 69.73% 69.73% -0.01%
==========================================
Files 1409 1409
Lines 235961 235961
==========================================
- Hits 164553 164552 -1
- Misses 71408 71409 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d6e8069
to
52ced32
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Because we now have a pull-request pipeline and a merge-queue, we think it is not necessary to run the main pipeline again after the merge. In addition, we also run the main-cron pipeline every day.
After removing the main pipeline, we can save at least 20% of CI costs.
Releated issue: close #12230
Checklist
./risedev check
(or alias,./risedev c
)