Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): init embedded connector node #12122
feat(connector): init embedded connector node #12122
Changes from 47 commits
2904555
2831bad
8e3fc67
bea170f
768776d
03664e9
37e530e
89d421f
61f5463
1f2d3ae
2e3c93f
41583db
3041df2
2dbbb51
ef0f0c8
a940f8d
d0ef67f
df9fc72
071b96d
738a2dd
d9562ff
4f4bb7f
018b332
25e1a8a
8b5b94a
41bd111
4b2089f
35ab88a
8bcce49
e16d040
cfa9e0e
5017dff
5a1bd7f
fb87e9c
0d7f770
336aae6
3b4233f
079520b
f55a545
a0901d2
170df20
a8d54ce
d5ee0fb
ae1327d
3a39f98
adc1a8d
547941b
67f0e72
cfa8ac6
0d87139
366eba9
dd0142b
c184ade
7208816
e6fbfde
ba14875
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For current code, we don't even need wrapping the channel with box, since the
tx
variable is dropped after the method is called. We can passchannel_ptr
as&tx as *const Sender as i64
.