Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cherry-pick): handle missing cache_policy field in OverWindow #12116

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Sep 6, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

cherry pick #12110

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested a review from lmatz September 6, 2023 05:39
@kwannoel kwannoel requested a review from a team as a code owner September 6, 2023 05:39
@kwannoel kwannoel changed the base branch from main to v1.2-rc September 6, 2023 05:40
@kwannoel kwannoel enabled auto-merge (squash) September 6, 2023 05:43
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #12116 (62e93d8) into v1.2-rc (616edbd) will decrease coverage by 0.01%.
Report is 1 commits behind head on v1.2-rc.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           v1.2-rc   #12116      +/-   ##
===========================================
- Coverage    69.79%   69.79%   -0.01%     
===========================================
  Files         1396     1396              
  Lines       234500   234504       +4     
===========================================
+ Hits        163661   163662       +1     
- Misses       70839    70842       +3     
Flag Coverage Δ
rust 69.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/stream/src/from_proto/over_window.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz lmatz disabled auto-merge September 6, 2023 07:00
@lmatz lmatz merged commit 27a7348 into v1.2-rc Sep 6, 2023
@lmatz lmatz deleted the kwannoel/chore branch September 6, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants