Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(kafka source): security properties are unhandled when protocol is not specified #9519

Closed
neverchanje opened this issue Apr 27, 2023 · 2 comments
Assignees
Milestone

Comments

@neverchanje
Copy link
Contributor

Describe the bug

When properties.security.protocol is not specified, RisingWave will just ignore other security properties.

To Reproduce

dev=> create source s with (
dev(>   connector = 'kafka',
dev(>   topic = 'kafka_1_partition_topic',
dev(>   properties.bootstrap.server = '127.0.0.1:29092',
dev(>   properties.sasl.mechanism= 'SCRAM-SHA-512',
dev(>   properties.sasl.username = 'alice',
dev(>   properties.sasl.password = 'alice-secret'
dev(> ) row format json;
CREATE_SOURCE

Expected behavior

Technically, the command should fail and warn that 'properties.security.protocol' is not specified.

Additional context

No response

@neverchanje neverchanje added type/bug Something isn't working priority/low labels Apr 27, 2023
@github-actions github-actions bot added this to the release-0.20 milestone Apr 27, 2023
@tabVersion
Copy link
Contributor

according to https://github.com/confluentinc/librdkafka/blob/master/CONFIGURATION.md , properties.security.protocol has a default value plaintext

@neverchanje
Copy link
Contributor Author

Ok. We should document it if it is the case.

@neverchanje neverchanje modified the milestones: release-1.0, release-1.1 Jul 21, 2023
@fuyufjh fuyufjh modified the milestones: release-1.1, release-1.2 Aug 8, 2023
@fuyufjh fuyufjh closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants