Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The dbz format is allowed to be created when using backhole sink. #9440

Closed
neverchanje opened this issue Apr 25, 2023 · 5 comments
Closed
Assignees

Comments

@neverchanje
Copy link
Contributor

neverchanje commented Apr 25, 2023

Describe the bug

create table t (v1 int, v2 int);
create sink invalid_dbz_type_sink from t with (connector = 'blackhole', type = 'debezium');

Expected behavior

It's supposed to fail but actually succeeded.

Additional context

NOTE:
Once fixed, please add the above test case in e2e_test/sink/append_only_sink.slt.

@neverchanje neverchanje added the type/bug Something isn't working label Apr 25, 2023
@github-actions github-actions bot added this to the release-0.20 milestone Apr 25, 2023
@xx01cyx
Copy link
Contributor

xx01cyx commented Apr 26, 2023

I believe we should introduce a better framework to check sink configurations in the connector node. We should be able to define fields as optional or required and specify possible values for each field in an easy way. cc @wenym1

@neverchanje neverchanje changed the title bug: The dbz format is allowed to be created when using jdbc sink. bug: The dbz format is allowed to be created when using backhole sink. Apr 26, 2023
@github-actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@fuyufjh
Copy link
Member

fuyufjh commented Aug 8, 2023

@tabVersion Can you please take a look?

@tabVersion
Copy link
Contributor

@tabVersion Can you please take a look?

@neverchanje what type is accepted in blackhole sink? or blackhole sink should not work with type attr

@tabVersion tabVersion removed this from the release-1.2 milestone Sep 11, 2023
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@tabVersion tabVersion closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants