Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve downstream primary key decision for sink #8346

Closed
xx01cyx opened this issue Mar 6, 2023 · 0 comments
Closed

Improve downstream primary key decision for sink #8346

xx01cyx opened this issue Mar 6, 2023 · 0 comments
Assignees
Milestone

Comments

@xx01cyx
Copy link
Contributor

xx01cyx commented Mar 6, 2023

Considering the fact that the downstream is accessible to the schema and might be able to generate a pk (e.g. JDBC), we could perform a not-so-strict primary key check on the sink:

  1. Try to fetch downstream's pk info.
  2. If the downstream has its own pk, use the downstream's pk. If not, use user-defined pk. If the user hasn't defined a pk, then we should reject the sink DDL.

Note that this should be done in meta, and should be part of sink validation.

Related: #7045 (comment)

@github-actions github-actions bot added this to the release-0.1.18 milestone Mar 6, 2023
@xx01cyx xx01cyx changed the title Improve primary key check for upsert sink Improve downstream primary key decision for sink Mar 6, 2023
@xx01cyx xx01cyx self-assigned this Mar 6, 2023
@xx01cyx xx01cyx closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant