Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OverWindow in the batch mode #7715

Closed
neverchanje opened this issue Feb 6, 2023 · 6 comments
Closed

feat: OverWindow in the batch mode #7715

neverchanje opened this issue Feb 6, 2023 · 6 comments
Milestone

Comments

@neverchanje
Copy link
Contributor

Describe the bug

On Postgres:

postgres=# create table t (groupid int, username varchar);
CREATE TABLE
postgres=# SELECT row_number() OVER ( PARTITION BY t.groupid ORDER BY t.username) AS usergroupid                                                                                                       FROM                                                                                                                           t;
 usergroupid
-------------
(0 rows)

But it fails on RisingWave:

ERROR:  QueryError: internal error: OverAgg can not be transformed. Plan:
LogicalProject { exprs: [ROW_NUMBER] }
└─LogicalOverAgg { window_function: ROW_NUMBER() OVER(PARTITION BY t.groupid ORDER BY t.username ASC NULLS LAST) }
  └─LogicalScan { table: t, columns: [groupid, username, _row_id] }

Is it a bug or a known issue?

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@neverchanje neverchanje added the type/bug Something isn't working label Feb 6, 2023
@github-actions github-actions bot added this to the release-0.1.17 milestone Feb 6, 2023
@xxchan
Copy link
Member

xxchan commented Feb 6, 2023

It's a known limitation. Currently we only support TopN pattern. General OverWindow (risingwavelabs/rfcs#8) is not implemented yet. cc @TennyZhuang is this feature on our recent schedule? 🤪

@xxchan xxchan removed the type/bug Something isn't working label Feb 6, 2023
@neverchanje
Copy link
Contributor Author

neverchanje commented Feb 6, 2023

We can consider adding the support for batch mode first. It won't require much effort.

@neverchanje neverchanje changed the title bug: OverAgg can not be transformed feat: OverWindow in the batch mode Feb 6, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Feb 20, 2023

@neverchanje Please reconfirm the req, thanks!

@neverchanje
Copy link
Contributor Author

neverchanje commented Mar 23, 2023

@fuyufjh Need some time for investigation. Will decide the deadline before Mar 27. 🙏

@fuyufjh
Copy link
Member

fuyufjh commented Jul 14, 2023

I think this will be done in next quarter's OKR. I'll close this first and @stdrc must have more detailed plans for it.

@fuyufjh fuyufjh closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
@stdrc
Copy link
Member

stdrc commented Jul 14, 2023

Yep we now have too many issues tracking over window🤣. Now I'm tracking batch over window feature in #9931 and overall task list in #9124.

BTW, FYI, batch over window will ready very soon, maybe a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants