Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Label that disables CI #6923

Closed
CAJan93 opened this issue Dec 15, 2022 · 6 comments
Closed

Chore: Label that disables CI #6923

CAJan93 opened this issue Dec 15, 2022 · 6 comments

Comments

@CAJan93
Copy link
Contributor

CAJan93 commented Dec 15, 2022

Is your feature request related to a problem? Please describe.

Maybe it would he helpful to have a label that disables CI? I am sometimes working on a draft and I know that this draft does not yet work at all. Testing it would be a waste of resources. It would be nice if we had a label that disables all testing in such a case.

Let me know what you think about such an idea.

@lmatz
Copy link
Contributor

lmatz commented Dec 16, 2022

I think it is a great idea that can save a lot of costs (more cost in the long term as we keep adding tests into CI and CI takes much longer time)

And there was a proposal for cases that should work in the other way around: #4941

@BugenZhao
Copy link
Member

BugenZhao commented Dec 16, 2022

Does adding a piece of [skip ci] to the commit body work for this case? While a label sounds better. 😄

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 16, 2022

I was not aware that you can write [skip ci]. Where exactly do I have to do that?

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 16, 2022

And there was a proposal for cases that should work in the other way around

@lmatz Do you have the issue link to that? For me both approaches are fine.

@lmatz
Copy link
Contributor

lmatz commented Dec 16, 2022

And there was a proposal for cases that should work in the other way around

@lmatz Do you have the issue link to that? For me both approaches are fine.

I just edit the thread above, actually not an approach but a use case

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 19, 2022

Thank you @lmatz. Let me know if I should close this ticket as a duplicate of #4941

@fuyufjh fuyufjh removed this from the release-0.1.16 milestone Jan 30, 2023
@fuyufjh fuyufjh assigned lmatz and unassigned huangjw806 Jan 30, 2023
@xxchan xxchan closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants