Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TMUX session does not end when node crashes #6467

Closed
CAJan93 opened this issue Nov 18, 2022 · 8 comments
Closed

TMUX session does not end when node crashes #6467

CAJan93 opened this issue Nov 18, 2022 · 8 comments
Assignees
@fuyufjh
Labels
help wanted Issues that need help from contributors priority/low type/bug Something isn't working

Comments

@CAJan93
Copy link
Contributor

CAJan93 commented Nov 18, 2022 •
edited
Loading

To Reproduce

Write a panic in one of your nodes, e.g. etcd

Watch the nodes risedev lsw see PR

risedev lsw
1: grafana
2: prometheus
3: etcd-2388
4: etcd-12388
5: etcd-1234 # THIS NODE CRASHES
6: meta-node-5690
7: meta-node-15690
9: compute-node-5688
10: frontend-4566

Expected behavior

The tmux session of the crashed node should exit.

risedev lsw
1: grafana
2: prometheus
3: etcd-2388
4: etcd-12388
6: meta-node-5690
7: meta-node-15690
9: compute-node-5688
10: frontend-4566

Additional context

No response
@CAJan93 CAJan93 added the type/bug Something isn't working label Nov 18, 2022
@github-actions github-actions bot added this to the release-0.1.15 milestone Nov 18, 2022
@CAJan93 CAJan93 mentioned this issue Nov 18, 2022
Merged
3 tasks
@CAJan93 CAJan93 added good first issue Good for newcomers help wanted Issues that need help from contributors priority/low labels Nov 18, 2022
@skyzh
Copy link
Contributor

skyzh commented Nov 24, 2022

Expected behavior. See run_command.sh.

@fuyufjh fuyufjh removed the good first issue Good for newcomers label Nov 28, 2022
@fuyufjh
Copy link
Member

fuyufjh commented Nov 28, 2022

Shall we close it?

@skyzh skyzh closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
@skyzh skyzh reopened this Nov 28, 2022
@skyzh
Copy link
Contributor

skyzh commented Nov 28, 2022

I think we should change the implementation of risedev l.

@CAJan93
Copy link
Contributor Author

CAJan93 commented Nov 28, 2022

I agree @skyzh. Maybe this is expected behaviour, but from a user perspective it was surprising to see nodes still being listed, even though they crashed.

@skyzh
Copy link
Contributor

skyzh commented Nov 28, 2022

Yep, let's see how to fix this...

@CAJan93
Copy link
Contributor Author

CAJan93 commented Nov 29, 2022 •
edited
Loading

Yep, let's see how to fix this...

Thank you for taking the task 👍 Let me know if you need a review :)

@fuyufjh fuyufjh assigned fuyufjh and unassigned skyzh Dec 19, 2022
@fuyufjh fuyufjh removed this from the release-0.1.17 milestone Feb 16, 2023
@CAJan93
Copy link
Contributor Author

CAJan93 commented Mar 6, 2024

Is there an update regarding this issue? Do we want to keep it around or should we close it?

@xxchan
Copy link
Member

xxchan commented Jul 9, 2024

No one seems to be interested in fixing this (Actually I have never used risedev ls 🤣

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuyufjh fuyufjh

Labels
help wanted Issues that need help from contributors priority/low type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skyzh @fuyufjh @CAJan93 @xxchan