Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: support create sink on logical view #6285

Closed
BugenZhao opened this issue Nov 10, 2022 · 2 comments
Closed

sink: support create sink on logical view #6285

BugenZhao opened this issue Nov 10, 2022 · 2 comments
Assignees
@yuhao-su
Labels
component/frontend Protocol, parsing, binder. component/meta Meta related issue. type/feature user-facing-changes Contains changes that are visible to users
Milestone
release-0.1.16

Comments

@BugenZhao
Copy link
Member

BugenZhao commented Nov 10, 2022 •
edited
Loading

As suggested by @lmatz, since we have added the (initial) support for VIEW after #6023, we can expose this functionality with CREATE SINK sink FROM logical_view and everything sounds reasonable. We can make this feature experimental and develop it for benchmarking purposes first.

We have a lot of code logic reused by CREATE SINK with CREATE MATERIALIZED VIEW, so I believe we can support it without much effort.

  1. Support binding any TableFactor in FROM.
  2. Correctly handle the lifecycle of SINK without materialized view on meta service.
  3. Resolve corner issues until Resolve logical view's dependants #6160, Resolve wildcard for view on creation #6161.

Originally posted by @BugenZhao in #5388 (comment)

As the VIEW seems incomplete for now, how about extending the syntax also to support CREATE SINK sink AS ... (just like creating materialized views)?
@BugenZhao BugenZhao added this to the next-release-0.1.15 milestone Nov 10, 2022
@BugenZhao BugenZhao added type/feature component/meta Meta related issue. component/frontend Protocol, parsing, binder. labels Nov 10, 2022
@tabVersion
Copy link
Contributor

Can we support sink directly from source without materializing anything after this?

@BugenZhao
Copy link
Member Author

Can we support sink directly from source without materializing anything after this?

Yes. That is exactly what it's for.

This was referenced Nov 21, 2022
Open
Closed
@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuhao-su yuhao-su

Labels
component/frontend Protocol, parsing, binder. component/meta Meta related issue. type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Milestone
release-0.1.16
Development

No branches or pull requests
4 participants
@lmatz @tabVersion @BugenZhao @yuhao-su