Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: QueryResultFetcher should add a shutdown channel to listen on task failure #4947

Closed
BowenXiao1999 opened this issue Aug 29, 2022 · 1 comment · Fixed by #5022
Closed
Assignees

Comments

@BowenXiao1999
Copy link
Contributor

Now, after all stages are scheduled, QueryResultFetcher will begin to work and use get_data to fetch results.

According to #3908 , the executor can not throw error through channels. It's possible that QueryResultFetcher may already start to work (All stages are created), but some other task get execution failed later, in this case the QueryResultFetcher won't know it.

One solution is to add a shutdown channel channel when running QueryResultFetcher, if one task execution fail, this shutdown channel will receive the info and return error.

cc @liurenjie1024

@liurenjie1024
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants