Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: should not display same error for mutiple times #4748

Closed
BowenXiao1999 opened this issue Aug 19, 2022 · 3 comments
Closed

style: should not display same error for mutiple times #4748

BowenXiao1999 opened this issue Aug 19, 2022 · 3 comments

Comments

@BowenXiao1999
Copy link
Contributor

BowenXiao1999 commented Aug 19, 2022

Now pgwire will display error in https://github.com/singularity-data/risingwave-dev/blob/6161ccb2828b2d5727c74bee31cf708ecb273b38/src/utils/pgwire/src/pg_protocol.rs.

So now sometimes same error message will be displayed mutiple times. (Some error is traced in kernel, and forward the msg up to pgwire, then pgwire trace it again).

if we do not trace in pgwire, some error may not be printed to log.... Not sure how to do it correctly.

@BowenXiao1999 BowenXiao1999 changed the title style: should not display an error for mutiple times style: should not display same error for mutiple times Aug 19, 2022
@xxchan
Copy link
Member

xxchan commented Aug 20, 2022

What about ONLY tracing in pgwire?

Maybe also problematic, since some errors will be lost #3908

@fuyufjh fuyufjh modified the milestone: release-0.1.13 Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@BowenXiao1999
Copy link
Contributor Author

I think we do not need to display error in pgwire.

Have removed some in #5942 so close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants