Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor hummock iterator local statics design #4736

Closed
MrCroxx opened this issue Aug 19, 2022 · 2 comments
Closed

refactor hummock iterator local statics design #4736

MrCroxx opened this issue Aug 19, 2022 · 2 comments
Labels
difficulty/medium Issues that need some knowledge of the whole system good first issue Good for newcomers help wanted Issues that need help from contributors type/feature
Milestone
release-2.2

Comments

@MrCroxx
Copy link
Contributor

MrCroxx commented Aug 19, 2022

The original hummock iterator local statics interface is not friendly. The local statics may be lost or added multiple times after someone modifies it (FYI #4706 #4723 ). The interface needs refactors.
@fuyufjh fuyufjh added this to the release-0.1.13 milestone Sep 5, 2022
@MrCroxx MrCroxx added the good first issue Good for newcomers label Sep 5, 2022
@skyzh skyzh added the difficulty/medium Issues that need some knowledge of the whole system label Sep 16, 2022
@fuyufjh
Copy link
Member

fuyufjh commented Sep 26, 2022 •
edited
Loading

Any updates?

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 10, 2022

Not working on this yet. 🥲

@wcy-fdu wcy-fdu assigned wcy-fdu and unassigned MrCroxx Oct 10, 2022
@wcy-fdu wcy-fdu added the help wanted Issues that need help from contributors label Nov 11, 2022
@wcy-fdu wcy-fdu removed their assignment Nov 16, 2022
@fuyufjh fuyufjh removed this from the release-0.1.14 milestone Nov 21, 2022
@MrCroxx MrCroxx added this to the release-2.2 milestone Oct 16, 2024
@MrCroxx MrCroxx closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium Issues that need some knowledge of the whole system good first issue Good for newcomers help wanted Issues that need help from contributors type/feature
Projects
None yet
Milestone
release-2.2
Development

No branches or pull requests
4 participants
@skyzh @fuyufjh @MrCroxx @wcy-fdu