-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test facility: find a more ergonomic way to build executors #3847
Comments
Found the stream executor reorg PR #2289 And initial builder PR #462
🤔 |
We can have sth like |
This also applies to expression, plan, etc. |
IIRC, the context is that when building stream executors, some executors needs some extra field but the others don't, then @cykbls01 introduced a builder trait to solve it. I think it's okay to remove it if it's not used anymore. |
That's indeed desired to enhance DX and help improves test coverage. Prior arts:
We may consider how to build executors easier as the next enhancement.
|
Updated: we may want to fix this style issue when enhancing test facilities.
Original issue:
from_proto
directory for all builders, but batch executors have them in each executor's file.The text was updated successfully, but these errors were encountered: