Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streaming: eliminate usages of RwError #3116

Closed
4 tasks done
Tracked by #4077
BugenZhao opened this issue Jun 10, 2022 · 2 comments · Fixed by #5407
Closed
4 tasks done
Tracked by #4077

streaming: eliminate usages of RwError #3116

BugenZhao opened this issue Jun 10, 2022 · 2 comments · Fixed by #5407
Labels
component/streaming Stream processing related issue. difficulty/medium Issues that need some knowledge of the whole system good first issue Good for newcomers help wanted Issues that need help from contributors type/refactor

Comments

@BugenZhao
Copy link
Member

BugenZhao commented Jun 10, 2022 •
edited
Loading

When we were refactoring the streaming executors with async-stream, we decided to also refactor the error type with the per-crate manner. For compatibility, we still capsulate some RwErrors in the StreamExecutorError.

https://github.com/singularity-data/risingwave/blob/f2c5758789ddd22ba6edbfeb6d7f5279ac919f9c/src/stream/src/executor/error.rs#L35-L57

After #2366 was introduced, we can start to eliminate these usages now.
@BugenZhao BugenZhao added good first issue Good for newcomers help wanted Issues that need help from contributors component/streaming Stream processing related issue. type/refactor labels Jun 10, 2022
@fuyufjh fuyufjh mentioned this issue Jul 21, 2022
Closed
8 tasks
@BugenZhao BugenZhao mentioned this issue Jul 22, 2022
Merged
3 tasks
@skyzh
Copy link
Contributor

skyzh commented Sep 2, 2022

Is this issue cleared? cc @BugenZhao

@BugenZhao
Copy link
Member Author

Is this issue cleared? cc @BugenZhao

I'm not sure, as we still rely on it for executor builders & stream manager. 🤔

@skyzh skyzh added the difficulty/medium Issues that need some knowledge of the whole system label Sep 16, 2022
@BugenZhao BugenZhao mentioned this issue Sep 17, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #5407 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/streaming Stream processing related issue. difficulty/medium Issues that need some knowledge of the whole system good first issue Good for newcomers help wanted Issues that need help from contributors type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(streaming): clean-up and disallow RwError in stream crate risingwavelabs/risingwave
2 participants
@skyzh @BugenZhao