Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explain (distsql, format dot) for dashboard to visualize graph #19542

Closed
kwannoel opened this issue Nov 22, 2024 · 5 comments
Closed

Use explain (distsql, format dot) for dashboard to visualize graph #19542

kwannoel opened this issue Nov 22, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors type/feature

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Nov 22, 2024

https://risingwave-labs.slack.com/archives/C034U0NH5ND/p1732267878599779?thread_ts=1732168127.133129&cid=C034U0NH5ND

Current the RW dashboard has a graph for distributed plan:
image

We can replace this with explain (format dot, distsql) and render it with graphviz.

We might not support distsql + format dot yet. This is a prerequisite for this task.

@github-actions github-actions bot added this to the release-2.2 milestone Nov 22, 2024
@kwannoel kwannoel added good first issue Good for newcomers help wanted Issues that need help from contributors labels Nov 22, 2024
@kwannoel kwannoel removed this from the release-2.2 milestone Nov 22, 2024
@kwannoel kwannoel changed the title Use explain (format dot) for dashboard to visualize graph Use explain (distsql, format dot) for dashboard to visualize graph Nov 23, 2024
@lyang24
Copy link
Contributor

lyang24 commented Nov 23, 2024

can i take this?

@kwannoel
Copy link
Contributor Author

can i take this?

Assigned, thanks!

@kwannoel
Copy link
Contributor Author

You can open 2 separate PRs. One for explain format dot distsql. Another for the dashboard changes.

@lyang24
Copy link
Contributor

lyang24 commented Nov 24, 2024

May not relate to this issue directly, just checked out the explain function on dashboard, from a user point of view - I felt like its easier to write the explain (distsql) xxx and get the graph output. Currently i have to paste the output json from terminal to the ui.

@kwannoel
Copy link
Contributor Author

kwannoel commented Nov 26, 2024

May not relate to this issue directly, just checked out the explain function on dashboard, from a user point of view - I felt like its easier to write the explain (distsql) xxx and get the graph output. Currently i have to paste the output json from terminal to the ui.

We can change this panel to a more general "render graphviz" panel. It can be used to render all kinds of explain queries.
The dashboard cannot directly run the SQL, we will need to manage access to the DB via the dashboard if we want to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors type/feature
Projects
None yet
Development

No branches or pull requests

2 participants