Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Alter Source|(Table with conns)'s connector's parameters in with option #18440

Open
2 tasks
st1page opened this issue Sep 6, 2024 · 2 comments
Open
2 tasks

Comments

@st1page
Copy link
Contributor

st1page commented Sep 6, 2024

ALTER TABLE/SOURCE <table name> CONNECTOR [CLEAN STATE] WITH (…)

  • without CLEAN STATE
    • In this case, just modify the stored parameters in the streaming plans
  • with CLEAN STATE, the user can change the table's connector.

more informations here. https://risingwave-labs.slack.com/archives/C069EV2Q5MK/p1721982104476979?thread_ts=1721815617.574089&cid=C069EV2Q5MK

@tabVersion
Copy link
Contributor

tabVersion commented Sep 23, 2024

In this case, just modify the stored parameters in the streaming plans

Does this mean users can do whatever they want as long as not changing the connector?
TBH, I vote for this behavior because it is hard to tell whether we should enforce clean state in some cases, eg. broker SSL cert expires and the broker is mounted to another domain. RisingWave cannot see the two broker_addrs as the same.

Copy link
Contributor

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants