Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot restart a cluster if license key is invalid #18401

Closed
hzxa21 opened this issue Sep 4, 2024 · 2 comments
Closed

cannot restart a cluster if license key is invalid #18401

hzxa21 opened this issue Sep 4, 2024 · 2 comments
Labels
type/bug Something isn't working
Milestone

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Sep 4, 2024

Describe the bug

Compute node will fail to start up if license key is invalid:

2024-09-04T13:56:29.941094867+08:00 ERROR risingwave_rpc_client::meta_client: failed to register worker, exiting... error=failed to add worker node: gRPC request to meta service failed: Internal error: cannot check CPU core limit due to license key error: invalid license key: InvalidToken

Error message/log

No response

To Reproduce

  • ./risedev d full

  • psql -h localhost -p 4566 -d dev -U root
    Run in SQL:

ALTER SYSTEM SET license_key TO 'invalid';
  • ./risedev k
  • ./risedev d full

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@hzxa21 hzxa21 added the type/bug Something isn't working label Sep 4, 2024
@github-actions github-actions bot added this to the release-2.1 milestone Sep 4, 2024
@hzxa21
Copy link
Collaborator Author

hzxa21 commented Sep 4, 2024

@BugenZhao Is this a bug or a feature

@BugenZhao
Copy link
Member

BugenZhao commented Sep 4, 2024

This is indeed a problem. But I suppose the frontend is still functional and users should be able to update their license key and fix that.

From another perspective, setting an invalid key should be a rare occurrence, unless the user fails to renew their license key on time. In this case, all paid features will no longer work and may even lead to recovery loop, so it is expected that the user will update it as soon as possible.

@fuyufjh fuyufjh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants