bug(source): schema.registry.name.strategy is not followed for encode protobuf

[xiangjinwu]

#11384

risingwave/src/frontend/src/handler/create_source.rs

Lines 195 to 208 in edb1493

	async fn extract_protobuf_table_schema(
	schema: &ProtobufSchema,
	with_properties: &WithOptionsSecResolved,
	format_encode_options: &mut BTreeMap<String, String>,
	) -> Result<Vec<ColumnCatalog>> {
	let info = StreamSourceInfo {
	proto_message_name: schema.message_name.0.clone(),
	row_schema_location: schema.row_schema_location.0.clone(),
	use_schema_registry: schema.use_schema_registry,
	format: FormatType::Plain.into(),
	row_encode: EncodeType::Protobuf.into(),
	format_encode_options: format_encode_options.clone(),
	..Default::default()
	};

Just acknowledging this fact. It will be fixed after format_encode_options parsing logic unification.

[xiangjinwu]

Not verified end-to-end:

diff --git a/src/frontend/src/handler/create_source.rs b/src/frontend/src/handler/create_source.rs
index 3f83c25fb3..bfede244da 100644
--- a/src/frontend/src/handler/create_source.rs
+++ b/src/frontend/src/handler/create_source.rs
@@ -193,20 +193,11 @@ async fn extract_debezium_avro_table_pk_columns(
 
 /// Map a protobuf schema to a relational schema.
 async fn extract_protobuf_table_schema(
-    schema: &ProtobufSchema,
+    info: &StreamSourceInfo,
     with_properties: &WithOptionsSecResolved,
     format_encode_options: &mut BTreeMap<String, String>,
 ) -> Result<Vec<ColumnCatalog>> {
-    let info = StreamSourceInfo {
-        proto_message_name: schema.message_name.0.clone(),
-        row_schema_location: schema.row_schema_location.0.clone(),
-        use_schema_registry: schema.use_schema_registry,
-        format: FormatType::Plain.into(),
-        row_encode: EncodeType::Protobuf.into(),
-        format_encode_options: format_encode_options.clone(),
-        ..Default::default()
-    };
-    let parser_config = SpecificParserConfig::new(&info, with_properties)?;
+    let parser_config = SpecificParserConfig::new(info, with_properties)?;
     try_consume_string_from_options(format_encode_options, SCHEMA_REGISTRY_USERNAME);
     try_consume_string_from_options(format_encode_options, SCHEMA_REGISTRY_PASSWORD);
     consume_aws_config_from_options(format_encode_options);
@@ -392,7 +383,7 @@ pub(crate) async fn bind_columns_from_source(
 
             Some(
                 extract_protobuf_table_schema(
-                    &protobuf_schema,
+                    &stream_source_info,
                     &options_with_secret,
                     &mut format_encode_options_to_consume,
                 )

[xiangjinwu]

schema.registry.name.strategy is being phased out.
https://github.com/risingwavelabs/risingwave-docs/pull/2660

Moving to a later milestone to either fix it or remove it.