Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should redact license key when showing system parameters #17922

Closed
BugenZhao opened this issue Aug 5, 2024 · 0 comments · Fixed by #17936
Closed

should redact license key when showing system parameters #17922

BugenZhao opened this issue Aug 5, 2024 · 0 comments · Fixed by #17936
Labels
component/meta Meta related issue. type/enhancement Improvements to existing implementation.
Milestone
release-2.0

Comments

@BugenZhao
Copy link
Member

license_key was made a system parameter to simplify online updates. However, this leads to a side effect that the license key can be logged or printed insecurely with other system parameters. We should address this to enhance the security.
@BugenZhao BugenZhao added type/enhancement Improvements to existing implementation. component/meta Meta related issue. labels Aug 5, 2024
@github-actions github-actions bot added this to the release-1.11 milestone Aug 5, 2024
This was referenced Aug 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/meta Meta related issue. type/enhancement Improvements to existing implementation.
Projects
None yet
Milestone
release-2.0
Development

Successfully merging a pull request may close this issue.

feat: redact license key when displaying to users risingwavelabs/risingwave
1 participant
@BugenZhao