Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add column in the source executor's state table to record its rate limit #17916

Closed
st1page opened this issue Aug 5, 2024 · 1 comment
Closed
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Aug 5, 2024

https://risingwave-labs.slack.com/archives/C034TRPKN1F/p1722842791017909

My concern is that we can alter the streaming limit for MVs. So for a source in different Streaming Job, the streaming limit could be different

@github-actions github-actions bot added this to the release-1.11 milestone Aug 5, 2024
@fuyufjh
Copy link
Member

fuyufjh commented Aug 6, 2024

I feel the the fact that “different streaming jobs are actually using different SourceExecutor” is too obscure to users, that’s why I proposed to reuse SourceExecutor.


Anyway, storing them in state table sounds definitely a misuse to me. Even we need to work out this idea, I’d like to consider some other approaches

@st1page st1page closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants