Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation's output state should be NULL on initialization #17905

Open
kwannoel opened this issue Aug 2, 2024 · 1 comment
Open

Aggregation's output state should be NULL on initialization #17905

kwannoel opened this issue Aug 2, 2024 · 1 comment
Labels

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Aug 2, 2024

Describe the bug

Aggregation executors (including approx percentile) currently only output their state in-between initial barrier and second barrier.

This means before that the materialized state is empty, rather than NULL.

It's a minor issue though. Since after the second barrier the state is normal.

Given that it's tricky to fix and not a critical issue (materialize expects barrier initially, and most executors don't expect any data in the first epoch committed to their state table), I will mark it as low priority.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@kwannoel kwannoel added the type/bug Something isn't working label Aug 2, 2024
@github-actions github-actions bot added this to the release-1.11 milestone Aug 2, 2024
@kwannoel kwannoel removed this from the release-1.11 milestone Aug 2, 2024
@kwannoel kwannoel changed the title State should be NULL on init Aggregation's output state should be NULL on initialization Aug 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant