Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(map): optimize MapRef to reduce more copy #17863

Open
Tracked by #17743
xxchan opened this issue Jul 30, 2024 · 4 comments
Open
Tracked by #17743

perf(map): optimize MapRef to reduce more copy #17863

xxchan opened this issue Jul 30, 2024 · 4 comments
Assignees

Comments

@xxchan
Copy link
Member

xxchan commented Jul 30, 2024

See #17690 (comment)

@github-actions github-actions bot added this to the release-1.11 milestone Jul 30, 2024
@xxchan
Copy link
Member Author

xxchan commented Jul 30, 2024

Perhaps we should refactor ListRef to use Arc<ArrayImpl>.

It seems our array implementation has flaws to support such kind of optimizations. Should we switch to arrow-rs? 🤪

@wangrunji0408
Copy link
Contributor

Should we switch to arrow-rs? 🤪

This is technically possible and I agree with it. But there will be endless migration work. 🤪

@BugenZhao
Copy link
Member

It seems our array implementation has flaws to support such kind of optimizations. Should we switch to arrow-rs? 🤪

Why? 😕 Can't we make it a enum to support both cases? Just like the idea of Cow.

@xxchan xxchan removed this from the release-2.0 milestone Aug 19, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants