-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch): expression's error handling #17844
Comments
I guess they chose the second one because their expression framework cannot be easily adapted for the first one 🤔 |
Previous issue: #4458 |
Thanks! I remember we did some discussion somewhere but I did not find it. |
...? 👀 |
added.. Sorry, I lost this part |
As a streaming database, I hope to keep the SQL features consistent among streaming (i.e. Alternatively, shall we introduce a session variable to expose the expression's |
IIUC, currently
Do you mean to support non-strict mode for batch via a session var? We can't support strict mode for streaming easily. (Perhaps better to call it |
Exactly. It makes sense to use
Yeah, agree. But I'd like to mention 'expression' as well, how about |
This issue has been open for 60 days with no activity. If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the You can also confidently close this issue as not planned to keep our backlog clean. |
Some users complains that they do not want some rows' expression error prevent the whole query's processing and result.
TRY()
functionpresto and trino do this
https://trino.io/docs/current/functions/conditional.html#try
https://prestodb.io/docs/current/functions/conditional.html#try
NOTE: after #12461, the rw's implementation of
eval_infallible
is not equal to thetry()
function in these systemsimplement your own try version of each function, such as
TRY_TO_DATE()
,TRY_CAST()
.duckdb, snowflake and databricks do this
https://duckdb.org/docs/sql/expressions/cast.html#try_cast (though it does not have other functions)
https://docs.snowflake.com/en/sql-reference/functions/try_to_date
https://docs.databricks.com/en/sql/language-manual/functions/try_cast.html
Personally, prefer the first one.
The text was updated successfully, but these errors were encountered: