Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(source): centralize format_encode_options parsing #17675

Open
xiangjinwu opened this issue Jul 12, 2024 · 0 comments
Open

refactor(source): centralize format_encode_options parsing #17675

xiangjinwu opened this issue Jul 12, 2024 · 0 comments
Assignees
@xiangjinwu
Labels
type/feature
Milestone
release-2.2

Comments

@xiangjinwu
Copy link
Contributor

Current:

  • frontend::handler::create_source converts from map<string, string> to StreamSourceInfo in proto
  • connector::parser converts from StreamSourceInfo to SpecificParserConfig

Preferred:

  • connector::parser converts from map<string, string> to SpecificParserConfig
  • Frontend, meta and compute all use the same connector::parser logic
  • No need to add new fields to StreamSourceInfo. They are already in map<string, string>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangjinwu xiangjinwu

Labels
type/feature
Projects
None yet
Milestone
release-2.2
Development

No branches or pull requests
1 participant
@xiangjinwu