Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick refactor: move some sink param determined in new (#17373) to branch release-1.9 #17376

Closed
github-actions bot opened this issue Jun 20, 2024 · 1 comment
Closed

cherrypick refactor: move some sink param determined in new (#17373) to branch release-1.9 #17376

github-actions bot opened this issue Jun 20, 2024 · 1 comment
Assignees
@st1page
Labels
cherry-pick

Comments

@github-actions
Copy link
Contributor

Cherry picking #17373 onto branch release-1.9\n\nThis PR/issue was created by cherry-pick action from commit af8f9a5.
@st1page
Copy link
Contributor

st1page commented Jun 21, 2024

I once mistakenly thought that this PR can fix something so I tagged it with the cherry-pick, but in reality, the previous implementation was not problematic, so this commit is just a simple refactoring.

@st1page st1page closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st1page st1page

Labels
cherry-pick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st1page