Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more supported type to avro map to jsonb #16963

Closed
xxchan opened this issue May 28, 2024 · 3 comments
Closed

add more supported type to avro map to jsonb #16963

xxchan opened this issue May 28, 2024 · 3 comments
Assignees

Comments

@xxchan
Copy link
Member

xxchan commented May 28, 2024

          > > In my mind, the best way to play with PG data types is to use the native map data type. As we have decided to do it in near future, I think for this PR we can ignore that requirement.

So my intention in this PR is to only allow very limited types (non controversial) in JSON now. And maybe enable more if requested by users in the future. The most urgent requesting this feature only needs map<string>. Do you want to allow more types in this PR? 🤔

IMO yes, because it's a quite simple work regardless of our arguments here. 😄 Otherwise, as long as one field inside the map is unsupported the function won't work (even if users don't care about that field), thus I feel that I would be unwilling to say we support it.

Originally posted by @fuyufjh in #16948 (comment)

@github-actions github-actions bot added this to the release-1.10 milestone May 28, 2024
@xxchan xxchan self-assigned this May 28, 2024
@xxchan
Copy link
Member Author

xxchan commented Jul 9, 2024

As discussed in #17485, we'd like to hear more from users before adding the support.

@xxchan xxchan removed this from the release-1.10 milestone Jul 9, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@xxchan
Copy link
Member Author

xxchan commented Sep 17, 2024

Since native map and to_jsonb(map) are both supported, we don't need to do this

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant