Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor opendal streaming uploader and deprecate the outer MonitoredSteramingUploader #16930

Closed
hzxa21 opened this issue May 24, 2024 · 2 comments
Assignees
Milestone

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented May 24, 2024

After #16929, MonitoredSteramingUploader will only be used by OpenDAL object store. However, the reporting metrics are not exactly what we want because I/O may or may not happen on opendal writer write calls and the I/O scheduling is done inside the implementation of opendal writer.

However, after apache/opendal#4638, whenever a I/O happens in the opendal writer, it will invoke the execute method provided by the Executor implemented by us. We should monitor I/O metrics in the Executor and deprecate the outer MonitoredStreamingUploader completely.

@github-actions github-actions bot added this to the release-1.10 milestone May 24, 2024
@hzxa21
Copy link
Collaborator Author

hzxa21 commented Jul 10, 2024

After #17198, the metrics related to streaming uploader has already been moved into opendal object store. I will try to see whether we can completely deprecate MonitoredSteramingUploader.

@hzxa21 hzxa21 modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@hzxa21 hzxa21 self-assigned this Jul 10, 2024
@hzxa21
Copy link
Collaborator Author

hzxa21 commented Aug 19, 2024

Resolved by #17198

@hzxa21 hzxa21 closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant