Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate File Source V1 #16645

Closed
fuyufjh opened this issue May 8, 2024 · 3 comments · Fixed by #17963
Closed

Deprecate File Source V1 #16645

fuyufjh opened this issue May 8, 2024 · 3 comments · Fixed by #17963
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented May 8, 2024

The new batch-reading feature was done for v2. #15358

Time to deprecate the old file source.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

@github-actions github-actions bot added this to the release-1.10 milestone May 8, 2024
@neverchanje
Copy link
Contributor

#16234

I once created a similar issue.

@fuyufjh
Copy link
Member Author

fuyufjh commented May 13, 2024

#16234 was closed by #16337.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

So, can we do this?

@tabVersion
Copy link
Contributor

#16234 was closed by #16337.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

So, can we do this?

Yes, not a big deal. Which version should it be?
& We can just do the conversion in the frontend, keeping the connector name as s3_v2 in both meta and CN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants