Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Display database & schema along with table names #16556

Closed
fuyufjh opened this issue Apr 30, 2024 · 1 comment · Fixed by #16610
Closed

feat(dashboard): Display database & schema along with table names #16556

fuyufjh opened this issue Apr 30, 2024 · 1 comment · Fixed by #16610

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Apr 30, 2024

Currently, there are only tables shown in dashboard. This was because when we develop dashboard in early stage, we don't care about schema & databases a lot. But today I think we need to fix it.

Note

Currently we are using the internal table catalog message to pass the information from Meta node to dashboard web frontend.

Example:

message Sink {
uint32 id = 1;
uint32 schema_id = 2;
uint32 database_id = 3;
string name = 4;
repeated plan_common.ColumnCatalog columns = 5;
// Primary key derived from the SQL by the frontend.
repeated common.ColumnOrder plan_pk = 6;
repeated uint32 dependent_relations = 7;
repeated int32 distribution_key = 8;
// User-defined primary key indices for the upsert sink.
repeated int32 downstream_pk = 9;
SinkType sink_type = 10; // to be deprecated
uint32 owner = 11;
map<string, string> properties = 12;
string definition = 13;
optional uint32 connection_id = 14;
optional uint64 initialized_at_epoch = 15;
optional uint64 created_at_epoch = 16;
string db_name = 17;
string sink_from_name = 18;
StreamJobStatus stream_job_status = 19;
SinkFormatDesc format_desc = 20;
// Target table id (only applicable for table sink)
optional uint32 target_table = 21;
// Cluster version (tracked by git commit) when initialized/created
optional string initialized_at_cluster_version = 22;
optional string created_at_cluster_version = 23;
// Whether it should use background ddl or block until backfill finishes.
CreateType create_type = 24;
}
message Subscription {
uint32 id = 1;
string name = 2;
string definition = 3;
repeated common.ColumnOrder plan_pk = 4;

Unfortunately, there are only database & schema IDs. This is reasonable because it's designed to be used internally in Meta service.

I think it's time to introduce a tailored message proto for dashboard display.

@BugenZhao
Copy link
Member

Related #15542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants