Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the planBase(schema...) of the StreamSink #16540

Closed
st1page opened this issue Apr 29, 2024 · 1 comment
Closed

bug: fix the planBase(schema...) of the StreamSink #16540

st1page opened this issue Apr 29, 2024 · 1 comment
Assignees
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Apr 29, 2024

It should filter the invisible columns because

let mut log_reader = log_reader
.transform_chunk(move |chunk| {
if visible_columns.len() != columns.len() {
// Do projection here because we may have columns that aren't visible to
// the downstream.
chunk.project(&visible_columns)
} else {
chunk
}
})
.monitored(metrics);

But It does not introduce issues so far because no place use the sink node's property.

@github-actions github-actions bot added this to the release-1.9 milestone Apr 29, 2024
@st1page st1page closed this as completed Apr 29, 2024
@st1page st1page reopened this Apr 29, 2024
@st1page
Copy link
Contributor Author

st1page commented Apr 30, 2024

For sink into table, the sink's schema does not filter all the invisible columns...

if self.sink.is_sink_into_table() {
processed_input.boxed()
} else {
self.log_store_factory
.build()
.map(move |(log_reader, log_writer)| {
let write_log_stream = Self::execute_write_log(
processed_input,
log_writer.monitored(self.sink_writer_param.sink_metrics.clone()),
actor_id,
);

@st1page st1page self-assigned this May 14, 2024
@st1page st1page modified the milestones: release-1.9, release-1.10 May 14, 2024
@st1page st1page modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@st1page st1page closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant