Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: background ddls are not cleaned after cancel followed by recovery #16532

Open
Tracked by #16612
kwannoel opened this issue Apr 29, 2024 · 3 comments
Open
Tracked by #16612
Assignees
Labels
type/bug Something isn't working

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Apr 29, 2024

Describe the bug

In Drop Stream Jobs, we immediately drop the table fragments.
Whereas in cancel stream jobs, we don't, we only do so once initial barrier for cancel is collected.
So after recovery, the stream job can still be present, if the barrier for cancelling the stream job was not collected.
Perhaps we can solve it by unifying drop and cancel logics.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@kwannoel kwannoel added the type/bug Something isn't working label Apr 29, 2024
@kwannoel kwannoel self-assigned this Apr 29, 2024
@github-actions github-actions bot added this to the release-1.9 milestone Apr 29, 2024
@kwannoel
Copy link
Contributor Author

Workaround: Trigger recovery first to shift ownership of stream job to barrier manager, then run the cancel stream job command, and trigger another recovery again to let it take effect.

@kwannoel
Copy link
Contributor Author

#14471

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant