Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test more pg-types of postgres-cdc #16455

Closed
KeXiangWang opened this issue Apr 23, 2024 · 5 comments
Closed

Test more pg-types of postgres-cdc #16455

KeXiangWang opened this issue Apr 23, 2024 · 5 comments

Comments

@KeXiangWang
Copy link
Contributor

Like enum, some of the postgres rows cannot be directly parsed by String. We need more tests to verify different types.
#16423 (comment)

@StrikeW
Copy link
Contributor

StrikeW commented Apr 24, 2024

More context: in cdc backfill we use Rust client to scan the upstream table, and we need to covert those rows in postgres format into our OwnedRow to store in our storage.
For data types not supported in RW we will fallback to VARCHAR, which is supported in the DebeziumJson parser but need additional work to handle the format conversion in cdc backfill. Note that this requirement also apply to other cdc connector support cdc-backfill, e.g. mysql-cdc. cc @fuyufjh

@StrikeW
Copy link
Contributor

StrikeW commented Apr 24, 2024

We can create a cdc backfill table in

CREATE TABLE IF NOT EXISTS postgres_all_types(
to cover the data type test.

@KeXiangWang
Copy link
Contributor Author

We can create a cdc backfill table in

Okk I can add this.

Copy link
Contributor

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@KeXiangWang
Copy link
Contributor Author

Done in

CREATE TABLE IF NOT EXISTS postgres_all_types(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants