Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rate limit case where there's an update record #16451

Closed
kwannoel opened this issue Apr 23, 2024 · 0 comments · Fixed by #16465
Closed

Handle rate limit case where there's an update record #16451

kwannoel opened this issue Apr 23, 2024 · 0 comments · Fixed by #16465
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Apr 23, 2024

Credit @stdrc for finding this.

Consider case where rate_limit=1. Then we have an update record. That corresponds to 2 rows.
In such a scenario we need to just emit the entire chunk.

                    let n = NonZeroU32::new(chunk.cardinality() as u32).unwrap();
                    // Ditto.
                    limiter.until_n_ready(n).await.unwrap();

TODO(kwannoel): Also test the append record code, to make sure that the update record is not split on calling StreamChunk::split / DataChunk::split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
2 participants