New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: disabled sqlsmith expressions #16293

Open

5 tasks

kwannoel opened this issue Apr 15, 2024 · 0 comments

Labels

good first issue type/feature

Contributor

kwannoel commented Apr 15, 2024 •

edited

Loading

Tracks why they are disabled, and how to enable them:

Functions:

sqrt: The generated input must be non-negative.
pow: The input types must be type-cast, if it's expected to be pow(numeric, numeric) rather than pow(double precision, double precision). Otherwise by default it binds literals to double precision, and outputs double precision which is incorrect.

Aggregations:

jsonb_object_agg: The generated field name must be non-null.
stddev_samp / var_samp: Both use sqrt.
approx_percentile. Not fully implemented yet. Needs within group.

The text was updated successfully, but these errors were encountered:

kwannoel added the type/feature label

github-actions bot added this to the release-1.9 milestone

kwannoel mentioned this issue

chore(sqlsmith): ban stddev_samp, var_samp since they use sqrt #16428

Merged

9 tasks

kwannoel added the good first issue label

kwannoel removed this from the release-1.9 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment