Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rate limit = -1 to disable rate limit or some other session var #16280

Closed
kwannoel opened this issue Apr 12, 2024 · 0 comments
Closed
Assignees
Milestone

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Apr 12, 2024

Currently, the behaviour of rate limit 0 is used for this purpose. But its behaviour is not entirely consistent, for example, when setting it locally in the with options, it will apply rate limit, and stall the entire stream (cr @tabVersion ).

To fix that, we need to support another way of disabling rate limit. And then make sure rate limit = 0 is setup in a way which doesn't block streams.

@github-actions github-actions bot added this to the release-1.9 milestone Apr 12, 2024
@kwannoel kwannoel self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant