Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove matviewgraph from pg_catalog.pg_matviews #16070

Closed
fuyufjh opened this issue Apr 2, 2024 · 3 comments · Fixed by #16246
Closed

remove matviewgraph from pg_catalog.pg_matviews #16070

fuyufjh opened this issue Apr 2, 2024 · 3 comments · Fixed by #16246
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Apr 2, 2024

The matviewgraph field in pg_catalog.pg_matviews is very large. Consider removing it because in most cases the users do not care about it. Also, as a field introduced by RisingWave, it should be placed in rw_materialized_views rather than here.

DF3259EF-2CB7-4E9E-B003-14EE286D2B2C

Should the f.fragments be here? I think we have some rw_ system tables for that.

Yeah it’s added by ourselves. https://www.postgresql.org/docs/current/view-pg-matviews.html I tend to remove it.

Yeah. It should be inside rw_materialized_views instead or rw_fragments perhaps.
But cloud will still need some way to query for it.

@github-actions github-actions bot added this to the release-1.8 milestone Apr 2, 2024
@fuyufjh
Copy link
Member Author

fuyufjh commented Apr 2, 2024

@arkbriar Can you please help to confirm this?

But cloud will still need some way to query for it.

We should use rw_catalog.rw_relation_info for querying fragments instead of pg_matviews.

@arkbriar
Copy link
Contributor

arkbriar commented Apr 2, 2024

@arkbriar Can you please help to confirm this?

But cloud will still need some way to query for it.

We should use rw_catalog.rw_table_fragments for querying fragments instead of pg_matviews.

Confirmed, it's used in a monitoring workflow. However, IIUC it can be safely ignored.

BTW, Is there any context for the question? I think the only thing that relies on the field is the portal. cc. @luotianchun for a double confirmation.

@luotianchun
Copy link
Contributor

@arkbriar Can you please help to confirm this?↳

But cloud will still need some way to query for it.↳

We should use rw_catalog.rw_table_fragments for querying fragments instead of pg_matviews.↳

Confirmed, it's used in a monitoring workflow. However, IIUC it can be safely ignored.↳

BTW, Is there any context for the question? I think the only thing that relies on the field is the portal. cc. @luotianchun for a double confirmation.↳

Yes, portal need it to show the mview DAG. And hopefully there will not be any changes to the data structure.

@fuyufjh fuyufjh self-assigned this Apr 8, 2024
@fuyufjh fuyufjh modified the milestones: release-1.8, release-1.9 Apr 8, 2024
fuyufjh added a commit that referenced this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants