Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: interval join's state cleaning with watermark does not take effect #16045

Closed
st1page opened this issue Apr 1, 2024 · 5 comments
Closed
Assignees

Comments

@st1page
Copy link
Contributor

st1page commented Apr 1, 2024

https://risingwave-community.slack.com/archives/C03BW71523T/p1711555567246409

@github-actions github-actions bot added this to the release-1.8 milestone Apr 1, 2024
@stdrc
Copy link
Member

stdrc commented Apr 8, 2024

After reviewing related code, I found that interval join state cleaning never guarantee to fully clean outdated states🥵...It only cleans states that match new-coming rows. And also in our doc we never say anything about state cleaning for interval join. I guess we may need further revisiting and even reimplementation on that part.

@stdrc stdrc modified the milestones: release-1.8, release-1.9 Apr 8, 2024
@stdrc stdrc removed this from the release-1.9 milestone May 10, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@fuyufjh
Copy link
Member

fuyufjh commented Sep 5, 2024

@fuyufjh
Copy link
Member

fuyufjh commented Sep 5, 2024

cc. @chenzl25 for awareness. Perhaps we need to do some action, either by documenting this or fix the problem

@chenzl25
Copy link
Contributor

chenzl25 commented Sep 5, 2024

The current implementation of interval join will clean the state when new messages come from upstream. I think we can document it clearly first.

@chenzl25 chenzl25 closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants