-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: interval join's state cleaning with watermark does not take effect #16045
Comments
After reviewing related code, I found that interval join state cleaning never guarantee to fully clean outdated states🥵...It only cleans states that match new-coming rows. And also in our doc we never say anything about state cleaning for interval join. I guess we may need further revisiting and even reimplementation on that part. |
This issue has been open for 60 days with no activity. If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the You can also confidently close this issue as not planned to keep our backlog clean. |
Related discussion: https://github.com/risingwavelabs/rfcs/pull/32/files#r1059266190 |
cc. @chenzl25 for awareness. Perhaps we need to do some action, either by documenting this or fix the problem |
The current implementation of interval join will clean the state when new messages come from upstream. I think we can document it clearly first. |
https://risingwave-community.slack.com/archives/C03BW71523T/p1711555567246409
The text was updated successfully, but these errors were encountered: