Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject FORMAT ENCODE options in WITH options #15824

Open
xxchan opened this issue Mar 20, 2024 · 1 comment
Open

Reject FORMAT ENCODE options in WITH options #15824

xxchan opened this issue Mar 20, 2024 · 1 comment
Assignees

Comments

@xxchan
Copy link
Member

xxchan commented Mar 20, 2024

e.g.,

CREATE SINK ...
WITH (
    ...
    timestamptz.handling.mode='utc_without_suffix'
) FORMAT UPSERT ENCODE JSON;

This will succeed, but utc_without_suffix doesn't work.
The correct version is

CREATE SINK ...
WITH (
    ...
) FORMAT UPSERT ENCODE JSON (
	timestamptz.handling.mode='utc_without_suffix'
);

We should reject the wrong version, instead of accepting it silently.

@github-actions github-actions bot added this to the release-1.8 milestone Mar 20, 2024
@xxchan
Copy link
Member Author

xxchan commented Mar 20, 2024

I think after #13762, the frontend's behavior changed, but

  • we didn't reject it in frontend
  • doc might also need to highlight the difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants