Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clickhouse sink): support JSONB by writing as string #15816

Open
fuyufjh opened this issue Mar 20, 2024 · 7 comments
Open

feat(clickhouse sink): support JSONB by writing as string #15816

fuyufjh opened this issue Mar 20, 2024 · 7 comments
Assignees

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Mar 20, 2024

ScalarRefImpl::Jsonb(_) => {
return Err(SinkError::ClickHouse(
"clickhouse rust interface can not support Json".to_string(),
))
}

Let's try to write JSONB as string. Hopefully it can just work.

@github-actions github-actions bot added this to the release-1.8 milestone Mar 20, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 8, 2024

@xxhZs Any updates?

@xxhZs
Copy link
Contributor

xxhZs commented Oct 8, 2024

Because ck supports jsonb, but it's clikchouse-rs that doesn't support jsonb, so for the time being, I'm not writing it as a string.

@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 8, 2024

Are we planning to add jsonb support in clickhouse-rs? If not, I will remove this issue from milestone first.

@xxhZs
Copy link
Contributor

xxhZs commented Oct 8, 2024

It looks as if their community is doing something similar, might be able to shut it down for now until their support is complete
ClickHouse/clickhouse-rs#144

@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 8, 2024

Blocked by: ClickHouse/clickhouse-rs#144

@hzxa21 hzxa21 removed this from the release-1.8 milestone Oct 8, 2024
@slvrtrn
Copy link

slvrtrn commented Nov 1, 2024

Using ClickHouse 24.10, you can now store/read the new JSON as a string. See the examples from this PR: ClickHouse/clickhouse-rs#171

It is now just a matter of a few settings that should be applied to the client instance (or per query/insert); the current client version should already be capable of doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants