Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use bitmap::iter_ones() instead of bitmap::iter() #15726

Open
st1page opened this issue Mar 17, 2024 · 1 comment
Open

perf: use bitmap::iter_ones() instead of bitmap::iter() #15726

st1page opened this issue Mar 17, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors no-issue-activity
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Mar 17, 2024

We have many logic like this

for ((a, b), vis) in aaa.iter()
.zip_eq(bbb.iter())
.zip_eq(chunk.visibility().iter()) {
   if !vis {
     continue
   }
   // do something
}

Use bitmap::iter_ones() can optimize the performance by skipping the invisible rows with SIMD bit operation #9278, especially when the selectivity visibility bitmap is low.

An example is #9329

@github-actions github-actions bot added this to the release-1.8 milestone Mar 17, 2024
@st1page st1page self-assigned this Apr 8, 2024
@st1page st1page added help wanted Issues that need help from contributors good first issue Good for newcomers labels Apr 8, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant