Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly-20240314 backfill performance degradation #15702

Closed
cyliu0 opened this issue Mar 15, 2024 · 4 comments
Closed

nightly-20240314 backfill performance degradation #15702

cyliu0 opened this issue Mar 15, 2024 · 4 comments

Comments

@cyliu0
Copy link
Collaborator

cyliu0 commented Mar 15, 2024

Describe the bug

https://buildkite.com/risingwave-test/backfill/builds/396

+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| BENCHMARK NAME                                                | EXECUTION ID | STATUS     | KEY METRICS                                        | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS | FLUCTUATION OF LAST EXECUTION |
+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        22907 | Negative   | backfill-create-mv-latency-per-100m-rows           | 10.96%              | 14.89%                      | 43.97%                        |
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        22907 | Negative   | backfill-create-watermark-mv-latency-per-100m-rows | 48.86%              | 37.87%                      | 26.71%                        |

http://metabase.risingwave-cloud.xyz/question/17042-backfill-datagen-100m-rows-medium-arm-all-affinity-backfill-create-watermark-mv-latency-per-100m-rows-ms-history-tltb-2959?start_date=2024-02-13

image

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

nightly-20230314

Additional context

https://github.com/risingwavelabs/rw-commits-history?tab=readme-ov-file#nightly-20240314

@cyliu0 cyliu0 added the type/bug Something isn't working label Mar 15, 2024
@github-actions github-actions bot added this to the release-1.8 milestone Mar 15, 2024
@cyliu0
Copy link
Collaborator Author

cyliu0 commented Mar 21, 2024

We have another performance degradation for nightly-20240320.

http://metabase.risingwave-cloud.xyz/dashboard/979-backfill-datagen-100m-rows-medium-arm-all-affinity-history?start_date=2024-02-16

image image
+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| BENCHMARK NAME                                                | EXECUTION ID | STATUS     | KEY METRICS                                        | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS | FLUCTUATION OF LAST EXECUTION |
+---------------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        23391 | Negative   | backfill-batch-query-latency-per-100m-rows         | 2.89%               | -0.31%                      | 1.51%                         |
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        23391 | Negative   | backfill-create-mv-latency-per-100m-rows           | 123.99%             | 56.97%                      | 49.61%                        |
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        23391 | Negative   | backfill-create-watermark-mv-latency-per-100m-rows | 131.89%             | 50.37%                      | 40.41%                        |
| backfill-datagen-100m-rows-medium-arm-all-affinity            |        23391 | Negative   | backfill-mv-query-latency-per-100m-rows            | 11.50%              | 5.59%                       | 10.18%                        |

@cyliu0
Copy link
Collaborator Author

cyliu0 commented Mar 27, 2024

Another backfill perf degradation for nightly-20240326

+--------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| BENCHMARK NAME                                         | EXECUTION ID | STATUS     | KEY METRICS                                        | FLUCTUATION OF BEST | FLUCTUATION OF LAST 10 DAYS | FLUCTUATION OF LAST EXECUTION |
+--------------------------------------------------------+--------------+------------+----------------------------------------------------+---------------------+-----------------------------+-------------------------------+
| backfill-datagen-100m-rows-medium-arm-all-affinity     |        23889 | Negative   | backfill-batch-query-latency-per-100m-rows         | 10.41%              | 5.66%                       | 3.14%                         |
| backfill-datagen-100m-rows-medium-arm-all-affinity     |        23889 | Negative   | backfill-create-mv-latency-per-100m-rows           | 73.13%              | 8.33%                       | 42.10%                        |
| backfill-datagen-100m-rows-medium-arm-all-affinity     |        23889 | Negative   | backfill-create-watermark-mv-latency-per-100m-rows | 105.71%             | 18.10%                      | 40.31%                        |
| backfill-datagen-100m-rows-medium-arm-all-affinity     |        23889 | Negative   | backfill-mv-query-latency-per-100m-rows            | 10.74%              | 4.52%                       | 4.71%                         |

@cyliu0 cyliu0 changed the title nightly-20230314 backfill performance degradation nightly-20240314 backfill performance degradation Mar 27, 2024
@hzxa21
Copy link
Collaborator

hzxa21 commented Apr 8, 2024

@Little-Wallace Can you help take a look?

@cyliu0
Copy link
Collaborator Author

cyliu0 commented Apr 30, 2024

According to the test result, it's fixed by #16519
Thanks @shanicky

@cyliu0 cyliu0 closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants