Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create sink into table fails due to cycle check #15643

Closed
kwannoel opened this issue Mar 12, 2024 · 0 comments · Fixed by #15639
Closed

create sink into table fails due to cycle check #15643

kwannoel opened this issue Mar 12, 2024 · 0 comments · Fixed by #15639
Assignees
@shanicky
Labels
type/bug Something isn't working
Milestone
release-1.8

Comments

@kwannoel
Copy link
Contributor

Create sink into table has cycle check, (check_cycle_for_sink).
This check fails when the upstream node is a source, since we use get_table_by_id. We need to consider source as well.
@kwannoel kwannoel added type/feature type/bug Something isn't working and removed type/feature labels Mar 12, 2024
@github-actions github-actions bot added this to the release-1.8 milestone Mar 12, 2024
@shanicky shanicky linked a pull request Mar 13, 2024 that will close this issue
fix: hotfix cycle check for sink from source #15639
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanicky shanicky

Labels
type/bug Something isn't working
Projects
None yet
Milestone
release-1.8
Development

Successfully merging a pull request may close this issue.

fix: hotfix cycle check for sink from source risingwavelabs/risingwave
2 participants
@shanicky @kwannoel