Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve coverage of with_options_sink.yaml #15537

Closed
hzxa21 opened this issue Mar 8, 2024 · 4 comments
Closed

improve coverage of with_options_sink.yaml #15537

hzxa21 opened this issue Mar 8, 2024 · 4 comments
Assignees
Milestone

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Mar 8, 2024

          I just realized that with options for cassandra sink are not included in this yaml. Let's revisit other sinks as well to ensure all sinks are covered.

Originally posted by @hzxa21 in #15516 (comment)

@github-actions github-actions bot added this to the release-1.8 milestone Mar 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@hzxa21
Copy link
Collaborator Author

hzxa21 commented Oct 8, 2024

@xxhZs Any updates?

@xxhZs
Copy link
Contributor

xxhZs commented Oct 11, 2024

Here it's because we only support similar logic for rust's sinks, and given that we have fewer and fewer java implementations of sinks, it's not clear if we'll still have to implement this check for java_sink

@hzxa21
Copy link
Collaborator Author

hzxa21 commented Oct 11, 2024

Fair enough. I will close this issue for now.

@hzxa21 hzxa21 closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants